On Mon, Mar 18, 2013 at 7:15 PM, Marko Kreen <markokr@gmail.com> wrote:
> On Mon, Mar 18, 2013 at 01:53:29PM +0000, Daniele Varrazzo wrote:
>> Unfortunately pgbouncer doesn't send the DateStyle setting on
>> connection, and psycopg conservatively sets DateStyle to ISO when the
>> information is missing: on pgbouncer this may mean an extra query
>> every query. Not amusing.
>
> I assume you are talking about the bug fixed in PgBouncer 1.4?
>
> Or are there problems with more recent versions of PgBouncer?
>
>> Because I'm going to release version 2.5 soon, so it's a good time to
>> break something. What I'd do is: if the DateStyle info is missing
>> (i.e. you are on pgbouncer or other "broken" middleware) just assume
>> the date style is correct.
>
> Good idea.
>
>> This would break dates adaptation for users
>> of a database with non-standard DateStyle (e.g. "German") running
>> through pgbouncer: for these users there is an easy fix: pass the
>> extra DateStyle=ISO option at connection, either in the connection
>> string:
>>
>> psycopg2.connect("host=here user=that options='-c DateStyle=ISO' ")
> [...]
> This suggestion is useless for PgBouncer as it will refuse such
> connection attempt. But maybe it will work on whatever other
> middleware you have in mind.
Because the issue should have been fixed in recent PgBouncer versions
and the suggested workaround wouldn't work, I'd not rush releasing
such a change, at least not until we get more information about the
issue.
-- Daniele