On Wed, Mar 5, 2025 at 4:00 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Ah. I was mistakenly assuming that 0001 would compile on its own ;-)
Oopsie.
> Got it. So does that mean we can remove any #include's from explain.h
> after moving the struct definition?
Good question. It looks like "lib/stringinfo.h" can come out but the
other two are still needed, so there is not much gain. But I've made
that change in the attached v4.
I also added "= NULL" to a couple of variable initialization in 0003
in this version, because Andres pointed out to me that cfbot was
seeing compiler warnings. It's a little odd that it warned, because
the variables were initialized by a switch over all enum values, but I
guess some compiler doesn't find that convincing enough.
--
Robert Haas
EDB: http://www.enterprisedb.com