On Sun, Sep 4, 2016 at 7:15 PM, Marko Tiikkaja <marko@joh.to> wrote:
> On 2016-05-09 19:42, Sherrylyn Branchaw wrote:
>>
>> I'm attaching a revised patch; please let me know if there are any other
>> issues before I submit to the commitfest.
>
> I think this is mostly good, but these two should be changed:
>
> errmsg("unexpected end of string: \"%s\"", state->begin)
> errmsg("syntax error at position %d: \"%s\"", ...)
>
> Right now, aside from the error code, these two look like they're reporting
> about an error in the SQL statement itself, and not in an input value for a
> type. I think they should look more like this:
>
> errmsg("invalid input syntax for type hstore: \"%s\"", string),
> errdetail("Unexpected end of input.")
>
> If possible, it might also make sense to provide more information than
> "unexpected end of string". For example: what character were you expecting
> to find, or what were you scanning? I didn't look too closely what exactly
> could be done here. I'll leave that part to you.
Since no revised patch has been forthcoming and the CommitFest is due
to end shortly, I've marked this "Returned with Feedback". Sherrylyn,
please feel free to update the patch and resubmit to the next
CommitFest.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company