On Thu, May 2, 2019 at 5:32 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> Yeah, at least in this patch it looks silly. Actually, I added that
> index to make the qsort stable when execute_undo_action sorts them in
> block order. But, as part of this patch we don't have that processing
> so either we can remove this structure completely as you suggested but
> undo processing patch has to add that structure or we can just add
> comment that why we added this index field.
Well, the qsort comparator could compute the index as ptr - array_base
just like any other code, couldn't it?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company