Re: pgbench - add option to show actual builtin script code

Поиск
Список
Период
Сортировка
Искать
От
Ibrar Ahmed
Тема
Re: pgbench - add option to show actual builtin script code
Дата
в 13:55:18
Msg-id
155680531862.1409.1208274148953704839.pgcf@coridan.postgresql.org
Ответ на
Список
Дерево обсуждения
pgbench - add option to show actual builtin script code Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - add option to show actual builtin script code Ibrar Ahmed <ibrar.ahmad@gmail.com>
Re: pgbench - add option to show actual builtin script code Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - add option to show actual builtin script code Ibrar Ahmed <ibrar.ahmad@gmail.com>
Re: pgbench - add option to show actual builtin script code Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - add option to show actual builtin script code Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: pgbench - add option to show actual builtin script code Fabien COELHO <coelho@cri.ensmp.fr>
Re: pgbench - add option to show actual builtin script code Thomas Munro <thomas.munro@gmail.com>
Re: pgbench - add option to show actual builtin script code Fabien COELHO <coelho@cri.ensmp.fr>
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Patch looks good to me, and work fine on my machine. One minor observation is option 'list' mostly used to list the elements like "pgbench -b list" shows the available builtin scripts. Therefore we should use a word which seems to be more relevant like --show-script.

The new status of this patch is: Waiting on Author
В списке pgsql-hackers по дате отправления
От: Robert Haas
Дата:
От: Simon Riggs
Дата:
FAQ