On Tue, Jan 20, 2015 at 10:54 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Mon, Jan 19, 2015 at 9:29 PM, Peter Geoghegan <pg@heroku.com> wrote:
>> I think that the attached patch should at least fix that much. Maybe
>> the problem on the other animal is also explained by the lack of this,
>> since there could also be a MinGW-ish strxfrm_l(), I suppose.
>
> Committed that, rather blindly, since it looks like a reasonable fix.
Peter, this made bowerbird (Windows 8/Visual Studio) build, but it's
failing make check. Ditto hamerkop (Windows 2k8/VC++) and currawong
(Windows XP Pro/MSVC++). jacana (Windows 8/gcc) and brolga (Windows
XP Pro/cygwin) are unhappy too, although the failures are showing up
in different build stages rather than in 'make check'. narwhal
(Windows 2k3/mingw) and frogmouth (Windows XP Pro/gcc) are happy,
though, so it's not affecting ALL of the Windows critters. Still, I'm
leaning toward the view that we should disable this optimization
across-the-board on Windows until somebody has time to do the legwork
to figure out what it takes to make it work, and what makes it work on
some of these critters and fail on others. We can't leave the
buildfarm red for long periods of time.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company