On Wed, Apr 29, 2020 at 5:52 AM Hamid Akhtar <hamid.akhtar@gmail.com> wrote:
> The idea and the patch looks good to me.
>
> It makes sense to change fread to basebackup_read_file which internally calls pg_pread which is a portable function
asopposed to read. As you've mentioned, this is much better for error handling.
Thanks for the review. I have now committed the patch, after rebasing
and adjusting one comment slightly.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company