> On 17 Jun 2020, at 17:45, Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Wed, Apr 29, 2020 at 5:52 AM Hamid Akhtar <hamid.akhtar@gmail.com> wrote:
>> The idea and the patch looks good to me.
>>
>> It makes sense to change fread to basebackup_read_file which internally calls pg_pread which is a portable function
asopposed to read. As you've mentioned, this is much better for error handling.
>
> Thanks for the review. I have now committed the patch, after rebasing
> and adjusting one comment slightly.
As this went in, can we close the 2020-07 CF entry or is there anything left in
the patchseries?
cheers ./daniel