Re: pg_archivecleanup bug

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: pg_archivecleanup bug
Дата
Msg-id CA+TgmoY7G0JsYjfGu57qQs7agwa7b3MqXOFbsKj50qrx3YH1sQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pg_archivecleanup bug  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Fri, Dec 6, 2013 at 11:10 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Thu, Dec 5, 2013 at 6:15 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> In general, I think there is no excuse for code in the backend to use
>>> readdir() directly; it should be using ReadDir(), which takes care of this
>>> as well as error reporting.
>
>> My understanding is that the fd.c infrastructure can't be used in the
>> postmaster.
>
> Say what?  See ParseConfigDirectory for code that certainly runs in the
> postmaster, and uses ReadDir().

Gosh, I could have sworn that I had calls into fd.c that were crashing
and burning during development because they happened too early in
postmaster startup.  But it seems to work fine now, so I've pushed a
fix for this and a few related issues.  Please let me know if you
think there are remaining issues.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Merlin Moncure
Дата:
Сообщение: Re: JSON decoding plugin
Следующее
От: Robert Haas
Дата:
Сообщение: Re: pg_archivecleanup bug