On Tue, Jun 12, 2012 at 7:43 PM, Dave Page <dpage@pgadmin.org> wrote:
On Tue, Jun 12, 2012 at 2:57 PM, Robert Haas <robertmhaas@gmail.com> wrote: > On Tue, Jun 12, 2012 at 8:53 AM, Dave Page <dpage@pgadmin.org> wrote: >>> Oh, I certainly wouldn't do it without *informing* and verifying it >>> with the user. >> >> That'll add additional steps for all users, and likely confuse the >> novices even more. > > The real issue here is that it's nuts to tell the user "please enter > either a new password or the password for the account that already > exists, but I'm not telling you which one".
That's a good point.
> What we need is to display a different dialogue based on the situation. > > If the account already exists, we should say "Please enter the > password for the existing postgres account. If you do not know the > password, you can reset it using the Windows control panel." > > But if it doesn't already exist, we should say "The installer will > create a postgres account on this machine. Please enter a password > for the new account." > > If we can do that, all of these problems will go away.
Yeah - that'll require some additional code to check if the account exists, but we can probably copy/paste that from the existing utility that creates the account (or better yet, refactor it to allow us to check or check & create as it does now).
Ashesh/Sachin/Dharam - do you see any potential issues with that?
Nope.. We do have the code to check whether the user exists or not..