Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence
Дата
Msg-id CA+OCxoyU2b0qa7x0f3COzLT2uoBEp9AgSPeVH4rMbm_BFDCH7w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Список pgadmin-hackers


On Wed, Feb 21, 2018 at 3:54 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Murtuza,
Looks good. 
Was there any reason for the change in position of the if statements in the sql file. Makes the output more readable?
Looks like we need some test to ensure that the Sequence issue does not happen again. Maybe a Unit Test is good enough, to ensure that we are creating a good SQL

I think we need to come up with a framework or standard method for testing the generated SQL and reverse engineered SQL for all objects. That's been bugging me for a while - the problem is that for just a single object type there may be thousands of possible combinations of options to test to ensure complete coverage.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin4] Priorities of features
Следующее
От: Dave Page
Дата:
Сообщение: Re: RM2898 Keyboard navigation in dialog tabs (nav tabs)