Re: Styling SQL box layout on dialogue
От | Dave Page |
---|---|
Тема | Re: Styling SQL box layout on dialogue |
Дата | |
Msg-id | CA+OCxoyB8NSB5V-5EmjGVjnbhg3O1iicvznfLO51Vfmm9U9ijg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Styling SQL box layout on dialogue (Arun Kollan <arun.kollan@enterprisedb.com>) |
Список | pgadmin-hackers |
OK, taking another look it seems like it's bit-rotted. Can you rebase please? Thanks. piranha:web dpage$ git pull Already up-to-date. piranha:web dpage$ git apply ~/Downloads/sql-box-layout-stylingv2.patch /Users/dpage/Downloads/sql-box-layout-stylingv2.patch:9: trailing whitespace. .pgadmin-controls.SQL { /Users/dpage/Downloads/sql-box-layout-stylingv2.patch:10: trailing whitespace. min-width: 290px; /Users/dpage/Downloads/sql-box-layout-stylingv2.patch:11: trailing whitespace. padding-right: 3px; /Users/dpage/Downloads/sql-box-layout-stylingv2.patch:12: trailing whitespace. padding-left: 1px; /Users/dpage/Downloads/sql-box-layout-stylingv2.patch:13: trailing whitespace. } error: patch failed: web/pgadmin/static/css/overrides.css:276 error: web/pgadmin/static/css/overrides.css: patch does not apply error: patch failed: web/pgadmin/static/js/backform.pgadmin.js:519 error: web/pgadmin/static/js/backform.pgadmin.js: patch does not apply On Mon, Apr 11, 2016 at 1:59 PM, Arun Kollan <arun.kollan@enterprisedb.com> wrote: > Hi Dave, > I asked Murtuza to apply the patch at his end and test on Chrome and > Firefox. We had a Skype session and it does appear to fix the issue. It > required a hard reload and cache clearing to get it working. > > I am assuming that the screenshot displayed is the dialogue window for > database properties. > > Regards, > Arun Kollan > Website: www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ > Follow us on Twitter: http://www.twitter.com/enterprisedb > > This e-mail message (and any attachment) is intended for the use of the > individual or entity to whom it is addressed. This message contains > information from EnterpriseDB Corporation that may be privileged, > confidential, or exempt from disclosure under applicable law. If you are not > the intended recipient or authorized to receive this for the intended > recipient, any use, dissemination, distribution, retention, archiving, or > copying of this communication is strictly prohibited. If you have received > this e-mail in error, please notify the sender immediately by reply e-mail > and delete this message. > > > > > On 11 Apr 2016, at 13:33, Dave Page <dave.page@enterprisedb.com> wrote: > > Still looks the same as my last screenshot to me. > > On Mon, Apr 11, 2016 at 11:31 AM, Arun Kollan > <arun.kollan@enterprisedb.com> wrote: > > Hi Dave, > Please find attached the zipped version of the patch. I have tested it > against the latest version from the repository. I had quick look comparing > the patches and it looks to contain the same rules. > > > Regards, > > Arun Kollan > Website: www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ > Follow us on Twitter: http://www.twitter.com/enterprisedb > > This e-mail message (and any attachment) is intended for the use of the > individual or entity to whom it is addressed. This message contains > information from EnterpriseDB Corporation that may be privileged, > confidential, or exempt from disclosure under applicable law. If you are not > the intended recipient or authorized to receive this for the intended > recipient, any use, dissemination, distribution, retention, archiving, or > copying of this communication is strictly prohibited. If you have received > this e-mail in error, please notify the sender immediately by reply e-mail > and delete this message. > > > > > On 11 Apr 2016, at 10:45, Arun Kollan <arun.kollan@enterprisedb.com> wrote: > > Hi Dave, > Looks the like the patch is out of sync with the repository. I will create > another patch now. > > Regards, > Arun Kollan > Website: www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ > Follow us on Twitter: http://www.twitter.com/enterprisedb > > This e-mail message (and any attachment) is intended for the use of the > individual or entity to whom it is addressed. This message contains > information from EnterpriseDB Corporation that may be privileged, > confidential, or exempt from disclosure under applicable law. If you are not > the intended recipient or authorized to receive this for the intended > recipient, any use, dissemination, distribution, retention, archiving, or > copying of this communication is strictly prohibited. If you have received > this e-mail in error, please notify the sender immediately by reply e-mail > and delete this message. > > > > > On 11 Apr 2016, at 10:09, Dave Page <dave.page@enterprisedb.com> wrote: > > On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan > <arun.kollan@enterprisedb.com> wrote: > > Hi Team, > > please find attached the patch for styling the sql editor on a dialogue > window. The separate rule has been written to include the style specific to > a control window. > > > There still seem to be padding/margin issues on my machine (under > Chrome). Am I missing something? > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > <Screen Shot 2016-04-11 at 10.07.08.png> > > > > > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake
В списке pgadmin-hackers по дате отправления:
Предыдущее
От: Akshay JoshiДата:
Сообщение: Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool