Re: [pgadmin-hackers][patch] Style updates
Hi
--
This introduces a number of display issues for me:
- There are now gaps between the tabs and their content panels. See screenshot 1.
- The tabs on the higher-level panels no longer match the styling of the tabs on dialogues, which still follow the original style.
- The font in detached/floating tabs is hard to read as I think it's too bold. We have similar outstanding problems in a couple of other places, mostly the dashboards and the subnode control headers.
- I think the white outline for detached/floating tabs is too harsh. Maybe make it a very light gray?
- I think the softened contrast in the query tool makes it much harder to visually distinguish different parts of the display. See ss2 for example - the info bar, codemirror gutter, codemirror text area and button bar all blend together now (yet, with the column selection patch you've gone perhaps too far the other way by making the row selector column in the grid dark blue to match the column headers).
- There's also a visible gap between the top of codemirror and the bottom of the info bar.
Overall I think this is heading in the right direction, but needs some tweaks to fix anomalies and increased contrast in a few places.
On Thu, Apr 6, 2017 at 4:24 PM, Atira Odhner <aodhner@pivotal.io> wrote:
This patch includes changes to the popped out mode as well as the right color background behind the buttons:Popped out:
Regular:Cheers!Tira & Shirley
On Wed, Apr 5, 2017 at 3:45 PM, Shirley Wang <swang@pivotal.io> wrote:Actually, we found an error with the patch and are going to resubmit it tomorrow once we fix the issue!ShirleyOn Wed, Apr 5, 2017 at 2:09 PM Atira Odhner <aodhner@pivotal.io> wrote:Hi Hackers,Matt and Sarah sat with our designer Shirley this week to do a couple of updates to the styles of the app. In particular, they changed the styles of the main tabs and the colors of the sql editor.Attached is a patch and a screenshot of the updated tabs and colors.
Tira & Matt
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
В списке pgadmin-hackers по дате отправления:
Предыдущее
От: Dave PageДата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix the issue in browser tree
Следующее
От: Dave PageДата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: Include an example of running just the featuretests.