Re: Patch for pgagent RM1878 [pgAgent]

Hi

On Mon, Oct 24, 2016 at 7:27 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> I mean reverse engineered sql tab. Currently it's not implemented for both
> pgagent schedule and jobs.

Yes it is - that's the change I made to your patch: "one change to
*enable* the SQL tabs everywhere".

> I have created Rm for that  RM1891

Please confirm it's working now, and update the ticket accordingly. It
won't hurt to have that listed as a separate change for 1.1.

> On Fri, Oct 21, 2016 at 8:30 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Thanks - applied, with one change to *enable* the SQL tabs everywhere.
>>
>> On Fri, Oct 21, 2016 at 2:41 PM, Harshal Dhumal
>> <harshal.dhumal@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA updated patch for RM1878
>> >
>> > Issues fixed:
>> >
>> > 1. ProgrammingError: can't adapt type 'Undefined' for schedule
>> > 2. Fixed malformed array literal issue raised by postgres while creating
>> > schedule
>> > 3. Fixed update of schedule.
>> > 4. Fixed update of step.
>> > 5. disabled sql tab (create sql tab) for step.
>> >
>> > --
>> > Harshal Dhumal
>> > Software Engineer
>> >
>> > EnterpriseDB India: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Fri, Oct 21, 2016 at 4:11 PM, Harshal Dhumal
>> > <harshal.dhumal@enterprisedb.com> wrote:
>> >>
>> >> Hi,
>> >>
>> >> Please ignore this patch as I haven't fixed same issue for schedule.
>> >> Also
>> >> there is issue "malformed array literal" when we try to save schedule.
>> >>
>> >> I'll be sending updated patch.
>> >>
>> >> Thanks Harshal,
>> >>
>> >> --
>> >> Harshal Dhumal
>> >> Software Engineer
>> >>
>> >> EnterpriseDB India: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> On Fri, Oct 21, 2016 at 2:51 PM, Harshal Dhumal
>> >> <harshal.dhumal@enterprisedb.com> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> PFA attached patch for pgagent issue RM1878
>> >>>
>> >>> issue fixed: ProgrammingError: can't adapt type 'Undefined'
>> >>>
>> >>> --
>> >>> Harshal Dhumal
>> >>> Software Engineer
>> >>>
>> >>> EnterpriseDB India: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company