Amit Langote <amitlangote09@gmail.com> writes: > On Thu, Jan 25, 2024 at 23:57 Tom Lane <tgl@sss.pgh.pa.us> wrote: >> -1 please. We should not break that abstraction for the sake >> of ignorable warnings on ancient compilers.
> Ignoring the warning was my 1st thought too, because an old discussion I > found about the warning was too old (2011). The style I adopted in my > “fix” is used in a few other places too, so I thought I might as well > go for it.
Oh, well maybe I'm missing some context. What comparable places did you see?
Sorry, not on my computer right now so can’t paste any code, but I was able to find a couple of functions (using Google ;) that refer to error_occurred directly for one reason or another: