Re: [PATCH] Cross-reference comments on signal handling logic

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: [PATCH] Cross-reference comments on signal handling logic
Дата
Msg-id C6D35968-AA00-49C1-AEAC-B78AB02FCB24@yesql.se
обсуждение исходный текст
Ответ на [PATCH] Cross-reference comments on signal handling logic  (Craig Ringer <craig.ringer@enterprisedb.com>)
Список pgsql-hackers
> On 1 Mar 2021, at 19:22, Mark Dilger <mark.dilger@enterprisedb.com> wrote:

>> On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig.ringer@enterprisedb.com> wrote:
>>
>> <v1-0001-Comments-and-cross-references-for-signal-handling.patch>
>
> In src/backend/postmaster/interrupt.c:
>
> + * These handlers are NOT used by normal user backends as they do not support
>
> vs.
>
> + * Most backends use this handler.
>
> These two comments seem to contradict.  If interrupt.c contains handlers that normal user backends to not use, then
howcan it be that most backends use one of the handlers in the file? 

I'm closing this as Returned with Feedback as it there has been no response to
the review comment during two commitfests.  Please reopen in a future
commitfest if you still would like to pursue this patch.

--
Daniel Gustafsson        https://vmware.com/




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Aleksander Alekseev
Дата:
Сообщение: Re: Table AM and DROP TABLE [ Was: Table AM and DDLs]
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: Column Filtering in Logical Replication