Обсуждение: [PATCH] Cross-reference comments on signal handling logic

Поиск
Список
Период
Сортировка

[PATCH] Cross-reference comments on signal handling logic

От
Craig Ringer
Дата:
Hi all

The attached comments-only patch expands the signal handling section in miscadmin.h a bit so that it mentions ProcSignal, deferred signal handling during blocking calls, etc. It adds cross-refs between major signal handling routines and the miscadmin comment to help readers track the various scattered but inter-related code.

I hope this helps some new developers in future.


Вложения

Re: [PATCH] Cross-reference comments on signal handling logic

От
Daniel Gustafsson
Дата:
> On 1 Mar 2021, at 19:22, Mark Dilger <mark.dilger@enterprisedb.com> wrote:

>> On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig.ringer@enterprisedb.com> wrote:
>>
>> <v1-0001-Comments-and-cross-references-for-signal-handling.patch>
>
> In src/backend/postmaster/interrupt.c:
>
> + * These handlers are NOT used by normal user backends as they do not support
>
> vs.
>
> + * Most backends use this handler.
>
> These two comments seem to contradict.  If interrupt.c contains handlers that normal user backends to not use, then
howcan it be that most backends use one of the handlers in the file? 

I'm closing this as Returned with Feedback as it there has been no response to
the review comment during two commitfests.  Please reopen in a future
commitfest if you still would like to pursue this patch.

--
Daniel Gustafsson        https://vmware.com/