On Sun, Nov 21, 2010 at 4:47 PM, Dimitri Fontaine
<dimitri@2ndquadrant.fr> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Sat, Nov 20, 2010 at 11:23 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> Ah, nuts. I see now there's a v7. Never mind...
>>
>> OK. I looked at the right version, now. Hopefully.
>
> Yeah, that was the most recent one and I linked it in the commit fest
> application. Given the very fast feedback I got, there has been a lot of
> activity and patches versions produced, so that's easy to get confused.
Especially because you also posted some revs of the ALTER EXTENSION ..
SET SCHEMA patch on this thread....
>> It seems we have no regression tests at all for any of the existing
>> SET SCHEMA commands. This seems like a good time to correct that
>> oversight, and also add some for the new commands you're adding here.
>
> Yeah, it's time for me to have a look at regression tests :)
>
> Please find attached set_schema.v8.patch with tests for the added
> commands in the patch.
>
>> (It might be helpful to submit the regression tests for the existing
>> commands as a separate patch.) Also, you're missing psql tab
>> completion support, which would be nice to have.
>
> Do you still want me to prepare another patch for adding in the tests
> the "set schema" variants that already existed but are not yet covered?
> Which are the one you did spot, btw?
[rhaas pgsql]$ git grep 'SET SCHEMA' src/test/regress/
[rhaas pgsql]$
> Completion support for psql. Isn't that stepping on David's toes? :)
> I'll see about that later if needed, maybe sometime tomorrow…
Please do. Tab completion support should really be included in the
patch - adding it as a separate patch is better than not having it, of
course.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company