> 12 янв. 2021 г., в 18:49, Heikki Linnakangas <hlinnaka@iki.fi> написал(а):
>
>> PFA patch with implementation.
>
> I did a bit of cleanup on the function signature. The .sql script claimed that gist_page_items() took bytea as
argument,but in reality it was a relation name, as text. I changed it so that it takes a page image as argument,
insteadof reading the block straight from the index. Mainly to make it consistent with brin_page_items(), if it wasn't
forthat precedence I might've gone either way on it.
bt_page_items() takes relation name and block number, that was a reason for doing so. But all others *_page_items()
(heap,brin, hash) are doing as in v4. So I think it's more common way.
>
> Fixed the docs accordingly, and ran pgindent. New patch version attached.
Thanks! Looks good to me.
One more question: will bytea tests run correctly on 32bit\different-endian systems?
Best regards, Andrey Borodin.