Re: please update ps display for recovery checkpoint

Поиск
Список
Период
Сортировка
От Bossart, Nathan
Тема Re: please update ps display for recovery checkpoint
Дата
Msg-id 9A1B9D98-4576-438A-943F-0AFB05946C7C@amazon.com
обсуждение исходный текст
Ответ на Re: please update ps display for recovery checkpoint  (Justin Pryzby <pryzby@telsasoft.com>)
Ответы Re: please update ps display for recovery checkpoint  (Justin Pryzby <pryzby@telsasoft.com>)
Список pgsql-hackers
Hi,

I like the idea behind this patch.  I wrote a new version with a
couple of changes:

    1. Instead of using StringInfoData, just use a small buffer along
       with snprintf().  This is similar to what the WAL receiver
       process does.
    2. If the process is the checkpointer, reset the display to "idle"
       once the checkpoint or restartpoint is finished.  It's easy
       enough to discover the backend type, and I think adding a bit
       more clarity to the checkpointer display is a nice touch.
    3. Instead of "running," use "creating."  IMO that's a bit more
       accurate.

I considered also checking that update_process_title was enabled, but
I figured that these ps display updates should happen sparsely enough
that it wouldn't make much of an impact.

What do you think?

Nathan


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Justin Pryzby
Дата:
Сообщение: copy.sgml and partitioned tables
Следующее
От: Alexander Korotkov
Дата:
Сообщение: Re: [HACKERS] [PATCH] Generic type subscripting