Re: Buglets in dlgFunction

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: Buglets in dlgFunction
Дата
Msg-id 937d27e10810180038t2b756e6fqe3f79b54e1f089f6@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Buglets in dlgFunction  (Guillaume Lelarge <guillaume@lelarge.info>)
Ответы Re: Buglets in dlgFunction  (Guillaume Lelarge <guillaume@lelarge.info>)
Список pgadmin-hackers
On Thu, Oct 16, 2008 at 3:38 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:

> Here is a new (complete) patch. I don't like at all what I did but it
> seems to fix your issues.

OK, here we go....

dlgTable:

Existing table: OK
New table: OK

dlgSequence:

Existing sequence: OK
New sequence: OK

dlgDatabase:

New database: OK
Existing database: OK

dlgPackage:

Existing package: OK
New package: OK

dlgTablespace:

New tablespace: OK
Existing tablespace: OK

dlgSchema:

Existing schema: OK
New schema: OK

dlgView:

Existing view: OK
New view: OK

Nice work!! So, let's please get this applied so we can put it to bed.
A couple of minor fixes:

- In dlgFunction::Go @367, you have:

    returncode = dlgSecurityProperty::Go(modal);

    returncode = dlgSecurityProperty::Go(modal);

Copy/paste error?

- Please add a comment to each instance of the ugly resize blocks to
explain what it's doing so we don't forget in 6 months :-)

Thanks!

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Guillaume Lelarge
Дата:
Сообщение: Re: Buglets in dlgFunction
Следующее
От: "Gevik Babakhani"
Дата:
Сообщение: Re: extending functionality strategy