Re: Extending amcheck to check toast size and compression

Поиск
Список
Период
Сортировка
Искать
От
Mark Dilger
Тема
Re: Extending amcheck to check toast size and compression
Дата
Msg-id
8E42250D-586A-4A27-B317-8B062C3816A8@enterprisedb.com
Ответ на
Re: Extending amcheck to check toast size and compression (Robert Haas)
Список
Дерево обсуждения
Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Justin Pryzby <pryzby@telsasoft.com>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Aleksander Alekseev <aleksander@timescale.com>
Re: Extending amcheck to check toast size and compression Heikki Linnakangas <hlinnaka@iki.fi>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Greg Stark <stark@mit.edu>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Greg Stark <stark@mit.edu>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Robert Haas <robertmhaas@gmail.com>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Robert Haas <robertmhaas@gmail.com>
Re: Extending amcheck to check toast size and compression Tom Lane <tgl@sss.pgh.pa.us>
Re: Extending amcheck to check toast size and compression Mark Dilger <mark.dilger@enterprisedb.com>
Re: Extending amcheck to check toast size and compression Aleksander Alekseev <aleksander@timescale.com> 


> On Nov 4, 2021, at 7:53 AM, Robert Haas  wrote:
> 
> But, is it plausible to add test coverage for the new checks, or is
> that going to be too much of a pain?

It only takes about 20 additional lines in the regression test to check the code paths for raw sizes which are too large and too small, so I've done that in this next version.  Testing corrupt compressed data in a deterministic, cross platform manner with a compact, easy to maintain regression test has eluded me and is not included here.



—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления
Предыдущее
От: Tomas Vondra
Дата:
Следующее
От: Jeff Davis
Дата:
FAQ