Re: pgindent vs. git whitespace check

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: pgindent vs. git whitespace check
Дата
Msg-id 7F679EEE-2860-47B8-B5DE-F7A5223ADFF9@yesql.se
обсуждение исходный текст
Ответ на Re: pgindent vs. git whitespace check  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: pgindent vs. git whitespace check  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers
> On 23 Feb 2023, at 05:48, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> For my own taste, I really don't have any objection to // in isolation --
> the problem with it is just that we've got megabytes of code in the other
> style.  I fear it'd look really ugly to have an intermixture of // and /*
> comment styles.

We could use the "use the style of surrounding code (comments)" approach - when
changing an existing commented function use the style already present; when
adding a net new function a choice can be made (unless we mandate a style).  It
will still look ugly, but it will be less bad than mixing within the same
block.

> Mass conversion of /* to // style would answer that,
> but would also create an impossible back-patching problem.

Yeah, that sounds incredibly invasive.

--
Daniel Gustafsson




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jim Jones
Дата:
Сообщение: Re: [PATCH] Add pretty-printed XML output option
Следующее
От: David Geier
Дата:
Сообщение: Re: pg_stat_statements and "IN" conditions