Re: pgindent vs. git whitespace check

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgindent vs. git whitespace check
Дата
Msg-id 346043.1677127729@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgindent vs. git whitespace check  (John Naylor <john.naylor@enterprisedb.com>)
Ответы Re: pgindent vs. git whitespace check
Re: pgindent vs. git whitespace check
Список pgsql-hackers
John Naylor <john.naylor@enterprisedb.com> writes:
> On Thu, Feb 23, 2023 at 5:03 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> I suspect not allowing // is at least a minor annoyance to any new
>> developer we acquire under the age of about 40.

> pgindent changes those to our style, so it's not much of an annoyance if
> one prefers to type it that way during development.

Right, it's not like we reject patches for that (or at least, we shouldn't
reject patches for any formatting issues that pgindent can fix).

For my own taste, I really don't have any objection to // in isolation --
the problem with it is just that we've got megabytes of code in the other
style.  I fear it'd look really ugly to have an intermixture of // and /*
comment styles.  Mass conversion of /* to // style would answer that,
but would also create an impossible back-patching problem.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Hayato Kuroda (Fujitsu)"
Дата:
Сообщение: RE: Allow logical replication to copy tables in binary format
Следующее
От: Jim Jones
Дата:
Сообщение: Re: [PATCH] Add pretty-printed XML output option