On 2019-12-19 04:59, Michael Paquier wrote:
> On Tue, Dec 17, 2019 at 11:56:17AM +0100, Peter Eisentraut wrote:
>> Yeah, good idea. Attached patch is refactored so all three header files
>> managed by AC_CONFIG_HEADERS are processed the same way.
>
> Looks good. I just have one comment.
>
> + # XXX
> + open(my $f, '>>', 'src/include/pg_config.h')
> + || confess "Could not write to src/include/pg_config.h\n";
> + print $f "\n";
> + print $f "#define VAL_CONFIGURE \""
> + . $self->GetFakeConfigure() . "\"\n";
> + close($f);
>
> This part needs a comment. Like it is the equivalent of what
> src/common/'s Makefile does or something like that?
This was meant to be addressed by
<https://www.postgresql.org/message-id/flat/6e457870-cef5-5f1d-b57c-fc89cfb8a788%402ndquadrant.com>,
but that discussion has not concluded yet. Perhaps it makes more sense
in this context.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services