On Thu, Dec 19, 2019 at 08:31:05AM +0100, Peter Eisentraut wrote:
> On 2019-12-19 04:59, Michael Paquier wrote:
>> This part needs a comment. Like it is the equivalent of what
>> src/common/'s Makefile does or something like that?
>
> This was meant to be addressed by
<https://www.postgresql.org/message-id/flat/6e457870-cef5-5f1d-b57c-fc89cfb8a788%402ndquadrant.com>,
> but that discussion has not concluded yet. Perhaps it makes more sense in
> this context.
Hmm. Your patch does not really change the generation of
VAL_CONFIGURE in pg_config.h, so I am not sure that this other thread
is an actual barrier for the improvement discussed here. I would be
actually fine to just remove the XXX and still use GetFakeConfigure()
with VAL_CONFIGURE for now. It would be a good thing to get rid of
pg_config.h.win32 definitely.
--
Michael