Re: Fix a failure of pg_dump with !HAVE_LIBZ

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Fix a failure of pg_dump with !HAVE_LIBZ
Дата
Msg-id 7601.1464278075@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Fix a failure of pg_dump with !HAVE_LIBZ  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Ответы Re: Fix a failure of pg_dump with !HAVE_LIBZ  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Список pgsql-hackers
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> The warning says that it makes uncompressed archive but it really
> doesn't since workers die unexpectedly from the succeeding
> errors. This is because that compressLevel is corrected in
> ReadHead(), where too late for it to be propagated to workers.
> One reasonable place would be where the default value of
> compressLevel is set in main().

Yeah, agreed.  I also noticed that you get the WARNING even when you
did not ask for compression, which seems rather unhelpful and annoying.
So I suppressed it by making the default be 0 not Z_DEFAULT_COMPRESSION
when we don't HAVE_LIBZ.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: ORDER/GROUP BY expression not found in targetlist
Следующее
От: Tom Lane
Дата:
Сообщение: Re: pg_dump -j against standbys