On 12/8/19 8:50 PM, Mark Dilger wrote:
>
>
> On 12/8/19 10:25 AM, Mark Dilger wrote:
>> I was
>> still expecting multiple patches, perhaps named along the
>> lines of:
>>
>> unshadow.RedoRecPtr.patch.1
>> unshadow.wal_segment_size.patch.1
>> unshadow.synchronous_commit.patch.1
>> unshadow.wrconn.patch.1
>> unshadow.progname.patch.1
>> unshadow.am_syslogger.patch.1
>> unshadow.days.patch.1
>> unshadow.months.patch.1
>>
>> etc. I'm uncomfortable giving you negative feedback of this
>> sort, since I think you are working hard to improve postgres
>> and I really appreciate it, so later tonight I'll try to come
>> back, split your patch for you as described, add an entry to
>> the commitfest if you haven't already, and mark myself as a
>> reviewer.
>
> To start off, I've taken just six of the 22 or so variables
> that you renamed and created patches for them. I'm not
> endorsing these in any way. I chose these mostly based on
> which ones showed up first in your patch file, with one
> exception.
>
> I stopped when I got to 'progname' => 'prog_name' as the
> whole exercise was getting too absurd even for me. That
> clearly looks like one where the structure of the code
> needs to be reconsidered, rather than just renaming stuff.
>
> I'll create the commitfest entry based on this email once
> this has been sent.
>
> Patches attached.
The commitfest item now exists at
https://commitfest.postgresql.org/26/2371/
--
Mark Dilger