> On Nov 16, 2021, at 8:11 PM, Jeff Davis <pgsql@j-davis.com> wrote:
>
> On Wed, 2021-11-03 at 12:50 -0700, Mark Dilger wrote:
>> The first two patches are virtually unchanged. The third updates the
>> behavior of the apply workers, and updates the documentation to
>> match.
>
> v2-0001 corrects some surprises, but may create others. Why is renaming
> allowed, but not changing the options? What if we add new options, and
> some of them seem benign for a non-superuser to change?
The patch cannot anticipate which logical replication options may be added to the project in some later commit. We can
letthat commit adjust the behavior to allow the option if we agree it is sensible for non-superusers to do so.
> The commit message part of the patch says that it's to prevent non-
> superusers from being able to (effectively) create subscriptions, but
> don't we want privileged non-superusers to be able to create
> subscriptions?
Perhaps, but I don't think merely owning a subscription should entitle a role to create new subscriptions.
Administratorsmay quite intentionally create low-power users, ones without access to anything but a single table, or a
singleschema, as a means of restricting the damage that a subscription might do (or more precisely, what the publisher
mightdo via the subscription.) It would be surprising if that low-power user was then able to recreate the
subscriptioninto something different.
We should probably come back to this topic in a different patch, perhaps a patch that introduces a new
pg_manage_subscriptionsrole or such.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company