Re: type in basebackup_incremental.c ?

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: type in basebackup_incremental.c ?
Дата
Msg-id 6946EFB1-626A-41B6-AE42-2C12950455EB@yesql.se
обсуждение исходный текст
Ответ на [MASSMAIL]type in basebackup_incremental.c ?  ("Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>)
Ответы Re: type in basebackup_incremental.c ?  ("Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>)
Re: type in basebackup_incremental.c ?  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
> On 11 Apr 2024, at 11:49, Daniel Westermann (DWE) <daniel.westermann@dbi-services.com> wrote:
>
> Hi,
>
> /*
>  * we expect the find the last lines of the manifest, including the checksum,
>  * in the last MIN_CHUNK bytes of the manifest. We trigger an incremental
>  * parse step if we are about to overflow MAX_CHUNK bytes.
>  */
>
> Shouldn't this be:
> /*
>  * we expect to find the last lines of the manifest,...
>  */

That sounds about right, and since it's a full sentence it should also start
with a capital 'W': "We expect to find the..".

--
Daniel Gustafsson




В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Daniel Westermann (DWE)"
Дата:
Сообщение: [MASSMAIL]type in basebackup_incremental.c ?
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: post-freeze damage control