Re: [HACKERS] document and use SPI_result_code_string()

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: [HACKERS] document and use SPI_result_code_string()
Дата
Msg-id 67DF9C0A-4187-430A-B39E-CB226FEFE9B0@yesql.se
обсуждение исходный текст
Ответ на Re: [HACKERS] document and use SPI_result_code_string()  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] document and use SPI_result_code_string()  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-hackers
> On 06 Sep 2017, at 14:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Michael Paquier <michael.paquier@gmail.com> writes:
>> Fine for 0002. This reminds me of LockGXact and RemoveGXact in
>> twophase.c, as well as _hash_squeezebucket that have some code paths
>> that cannot return... Any thoughts about having some kind of
>> PG_NOTREACHED defined to 0 which could be put in an assertion?
> 
> Generally we just do "Assert(false)", maybe with "not reached" in a
> comment.  I don't feel a strong need to invent a new way to do that.

Moving this to the next commitfest and bumping status to Ready for committer
based on the discussion in this thread.

cheers ./daniel


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Daniel Gustafsson
Дата:
Сообщение: Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: [HACKERS] Explicit relation name in VACUUM VERBOSE log