Re: BUG #16046: xpath returns CDATA tag along with the value inpostgres 12

Поиск
Список
Период
Сортировка
От Markus Winand
Тема Re: BUG #16046: xpath returns CDATA tag along with the value inpostgres 12
Дата
Msg-id 66578EEF-C7B2-493A-B88F-0FB0A833629A@winand.at
обсуждение исходный текст
Ответ на Re: BUG #16046: xpath returns CDATA tag along with the value inpostgres 12  (Chapman Flack <chap@anastigmatix.net>)
Список pgsql-bugs
Дерево обсуждения

On 25 Oct 2019, at 01:34, Chapman Flack <chap@anastigmatix.net> wrote:

On 10/24/19 19:14, Chapman Flack wrote:
<![CDATA[select 5 & 6 <yahoo!>]]>
select 5 &amp; 6 &lt;yahoo!&gt;

Either form of result is correct, and having it respect the form that was
used in the input might even be delightfully smart.

I haven't looked in the code just now to see if it is intentionally being
delightfully smart, or more simplistic-and-lucky.

It appears to be probably unintentional-but-ok: libxml tags a CDATA
section differently (XML_CDATA_SECTION_NODE) than a text node
(XML_TEXT_NODE), so a CDATA node falls into the catch-all branch of

if (cur->type != XML_ATTRIBUTE_NODE && cur->type != XML_TEXT_NODE)

This was intentional. Earlier versions of the patch had the CDATA explicitly listed[0]. I suggested to reverse the logic later [1].

My concern at that time was about xmltable but I think the current behavior is fine for xpath too. If you pick fragment(s) out of an XML document the most reasonable thing to do is to return that part(s) of the XML as it actually appears in the input.

 We could choose to say that's
what we meant it to do all along.

+1

-markus


В списке pgsql-bugs по дате отправления:

Предыдущее
От: PG Bug reporting form
Дата:
Сообщение: BUG #16078: Problems starting and running the app stack builder
Следующее
От: Tom Lane
Дата:
Сообщение: Re: BUG #16046: xpath returns CDATA tag along with the value in postgres 12