Re: psql: add \si, \sm, \st and \sr functions to show CREATE commands for indexes, matviews, triggers and tables

Поиск
Список
Период
Сортировка
От a.pervushina@postgrespro.ru
Тема Re: psql: add \si, \sm, \st and \sr functions to show CREATE commands for indexes, matviews, triggers and tables
Дата
Msg-id 64ea914ae88f31e9b316ef2a05c3e62c@postgrespro.ru
обсуждение исходный текст
Ответ на Re: psql: add \si, \sm, \st and \sr functions to show CREATE commands for indexes, matviews, triggers and tables  (Anna Akenteva <a.akenteva@postgrespro.ru>)
Ответы Re: psql: add \si, \sm, \st and \sr functions to show CREATE commands for indexes, matviews, triggers and tables  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Anna Akenteva wrote 2020-08-11 13:37:
> About the patch:
> 
> 1) There is some code duplication for the exec_command_[sm|si|st|sr]
> functions. Plus, it seems weird to separate sm (show matview) from sv
> (show view). Perhaps it would be more convenient to combine some of
> the code? Maybe by editing the already-existing exec_command_sf_sv()
> function.

I've combined most of the functions into one, as the code was mostly 
duplicated. Had to change the argument from is_func to object type, 
because the number of values has increased. I've attached a patch with 
those changes.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Mark Wong
Дата:
Сообщение: Re: doc examples for pghandler
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits