Re: Materialized view assertion failure in HEAD

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Materialized view assertion failure in HEAD
Дата
Msg-id 6476.1363362471@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Materialized view assertion failure in HEAD  (Kevin Grittner <kgrittn@ymail.com>)
Ответы Re: Materialized view assertion failure in HEAD  (Kevin Grittner <kgrittn@ymail.com>)
Список pgsql-hackers
Kevin Grittner <kgrittn@ymail.com> writes:
> I failed to touch everything necessary to prevent MVs from having
> OIDs.� This patch fixes the reported problem, and doesn't leave any
> gaps as far as I know; but I will do additional review to try to
> catch any other omissions.� I figured I should address the reported
> problem now, though.

> Will push later today if there are no objections.

I object --- that's not a fix, that's a crude hack.  It should not be
necessary to introduce relkind tests there.  Determination of whether
OIDs exist in the target table should happen well upstream, ie in
whatever is constructing the intoClause.  Otherwise we'll be fixing
code that examines the intoClause until doomsday.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kevin Grittner
Дата:
Сообщение: Re: Materialized view assertion failure in HEAD
Следующее
От: Kevin Grittner
Дата:
Сообщение: Re: Materialized view assertion failure in HEAD