Re: Patch for ALTER DATABASE WITH TABLESPACE

Guillaume Lelarge <guillaume@lelarge.info> writes:
> Bernd Helmle a �crit :
>> Maybe this is nit-picking, but i see that you have to rmdir() an
>> existing empty tablespace directory to use copydir() afterwards. Maybe
>> we can teach copydir() to error out when trying to mkdir() an existing
>> directory only when forced by the caller? I see copydir() used at four
>> places, so the impact of this change would be minimal.

> I don't think this is nit-picking. I think about it too myself when I
> did v4 and v5. I wasn't so sure, I prefered not to change this function
> because it's used on important parts of the code (createdb and redo wal).

I like the v5 version better too.

Bernd, did you have any further comments?  If not I'll get started on
this patch.
        regards, tom lane