Re: Fix for pg_upgrade and invalid indexes

Andres Freund <andres@2ndquadrant.com> writes:
> Those columns cannot be NULL, so using IS DISTINCT FROM seems a bit
> clumsy.

That was what I started to write, too, but actually I think the IS
DISTINCT is correct and the RIGHT JOIN should be a LEFT JOIN.  Note
that the query appears to be intended to collect regular tables as
well as indexes.  (As patched, that's totally broken, so I infer
Bruce hasn't tested it yet.)
        regards, tom lane