Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

Поиск
Список
Период
Сортировка
От Brar Piening
Тема Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Дата
Msg-id 5b5f6cdd-e003-bbc2-7bed-b7847e9660b3@gmx.de
обсуждение исходный текст
Ответ на Doc: Rework contrib appendix -- informative titles, tweaked sentences  ("Karl O. Pinc" <kop@karlpinc.com>)
Ответы Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences  ("Karl O. Pinc" <kop@karlpinc.com>)
Список pgsql-hackers
On 03.01.2023 at 01:00, Karl O. Pinc wrote:
> Attached is a patch: contrib_v1.patch
>
> It modifies Appendix F, the contrib directory.

Review:

The patch applies cleanly (1334b79a35 - 2023-01-14 18:05:09 +0900).

It adds a brief explanatory part to the headers of all contrib modules
which I consider as very useful, especially when looking at the TOC in
contrib.html where currently newcomers would need to click through all
the links to even get an idea what the various modules do.
The explanatory parts added make sense to me, althogh I'm not an expert
in all the different contrib modules.

Appendix F. now reads as "Additional Supplied Modules and Extensions"
instead of "Appendix F. Additional Supplied Modules" which IMHO proprely
reflects what it is about. The original title probably comes from the
pre-extension-era.

There is also some minor rewording of sentences in contrib.sgml that in
general looks like an improvment to me.

In conclusion I cannot see why this patch should not be applied in it's
current form so I deem it ready for commiter.

Regards,
Brar




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ajin Cherian
Дата:
Сообщение: Re: Support logical replication of DDLs
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: On login trigger: take three