Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw

Поиск
Список
Период
Сортировка
От Etsuro Fujita
Тема Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw
Дата
Msg-id 5A9E76FE.9070703@lab.ntt.co.jp
обсуждение исходный текст
Ответ на Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
Ответы Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw  (Jeff Davis <pgsql@j-davis.com>)
Список pgsql-hackers
(2018/03/06 1:57), Arthur Zakirov wrote:
> IMHO, it is worth to add more explaining comment into
> deparseReturningList, why it is necessary to merge WCO attributes to
> RETURNING clause. You already noted it in the thread. I think it could
> confuse someone who not very familiar how RETURNING is related with WITH
> CHECK OPTION.

Agreed.  I added a comment to that function.  I think that that comment 
in combination with changes to the FDW docs in the patch would help FDW 
authors understand why that is needed.  Please find attached an updated 
version of the patch.

Thanks for the comments!

Best regards,
Etsuro Fujita

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Anton Dignös
Дата:
Сообщение: Re: IndexJoin memory problem using spgist and boxes
Следующее
От: Ivan Kartyshov
Дата:
Сообщение: Re: [HACKERS] make async slave to wait for lsn to be replayed