On 04/24/2018 06:09 AM, Kyotaro HORIGUCHI wrote:
>
> It seems that the additional description needs to be meld into
> this at the first place? And some caveat may be needed on failure
> cases.
That's right. I applied your diff and rewrote these paragraphs, adding
some words about the possible loss of messages and how to fix it. I also
removed the forgotten declaration of CheckLogrotateSignal from xlog.h.
The updated patch is attached.
We should probably have a commitfest entry for this, so here it is:
https://commitfest.postgresql.org/18/1622/
--
Alexander Kuzmenkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company