Re: pgsql: Separate block sampling functions

On 05/15/2015 07:44 AM, Andrew Dunstan wrote:
>
> On 05/15/2015 06:04 AM, Simon Riggs wrote:
>> On 15 May 2015 at 04:59, Tom Lane <tgl@sss.pgh.pa.us
>> <mailto:tgl@sss.pgh.pa.us>> wrote:
>>
>>     The difference there was that that was specifically adding a new
>>     feature
>>     of value to FDWs.  This is just drive-by breakage.
>>
>>
>> I think that comment is reasonable. I will continue with my commits
>> of tablesample, then return to see if we can improve/revert the API
>> breakage.
>>
>>
>
>
> OK, good, but I'm not going to accept Michael's pull request until the
> API is stable.
>
>



What is the current state of this? Are we sticking with what Tom
classified as drive-by breakage?

cheers

andrew