On 06/04/15 14:30, Petr Jelinek wrote:
> On 06/04/15 11:02, Simon Riggs wrote:
>
>> Are we ready for a final detailed review and commit?
>>
>
> I plan to send v12 in the evening with some additional changes that came
> up from Amit's comments + some improvements to error reporting. I think
> it will be ready then.
>
Ok so here it is.
Changes vs v11:
- changed input parameter list to expr_list
- improved error reporting, particularly when input parameters are wrong
- fixed SELECT docs to show correct syntax and mention that there can be
more sampling methods
- added name of the sampling method to the explain output - I don't like
the code much there as it has to look into RTE but on the other hand I
don't want to create new scan node just so it can hold the name of the
sampling method for explain
- made views containing TABLESAMPLE clause not autoupdatable
- added PageIsAllVisible() check before trying to check for tuple visibility
- some typo/white space fixes
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services