On 3/4/15 11:00 PM, Andrew Dunstan wrote:
>
> On 03/04/2015 10:37 PM, Peter Eisentraut wrote:
>> On 2/15/15 6:55 AM, Michael Paquier wrote:
>>> I tested quickly the second patch with MS 2010 and I am getting a
>>> build failure: chkpass cannot complete because of crypt missing. On
>>> master build passes. More details here:
>>> "C:\Users\mpaquier\git\postgres\pgsql.sln" (default target) (1) ->
>>> "C:\Users\mpaquier\git\postgres\chkpass.vcxproj" (default target)
>>> (36) ->
>>> (Link target) ->
>>> chkpass.obj : error LNK2019: unresolved external symbol crypt
>>> referenced in function chkpass_in
>>> [C:\Users\ioltas\git\postgres\chkpass.vcxproj]
>>> .\Release\chkpass\chkpass.dll : fatal error LNK1120: 1 unresolved
>>> externals [C:\Users\mpaquier\git\postgres\chkpass.vcxproj]
>> I can't tell from just looking at the code how chkpass would normally
>> find crypt. The msvc tools neither parse SHLIB_LINK nor have hardcoded
>> knowledge. Any idea?
> Which library is it in? There are sections at the top of Mkvcbuild.pm
> for including various libraries in contrib modules that need them.
This is contrib/chkpass not finding the crypt symbol, which is
presumably in some library. But I can't see how it would normally find
it, without my patch.