Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Дата
Msg-id 53D7AF47.5020806@vmware.com
обсуждение исходный текст
Ответ на Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
Дерево обсуждения 
On 07/29/2014 05:10 PM, Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
>> Treat 2PC commit/abort the same as regular xacts in recovery.
>
> Looking at this again ... didn't you just break recoveryStopsBefore?
> ISTM the added line
>
>     if (record_info == XLOG_XACT_COMMIT_PREPARED)
>
> needs to be
>
>     else if (record_info == XLOG_XACT_COMMIT_PREPARED)
>
> As it stands, control will reach the "return false" for regular
> commit records.

Oops :-(. Fixed, thanks!

- Heikki

В списке pgsql-committers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: pgsql: Oops, fix recoveryStopsBefore functions for regular commits.
Следующее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Simplify multixact freezing a bit