Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Дата
Msg-id 31263.1406643002@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
Ответы Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Список pgsql-committers
Дерево обсуждения 
Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
> Treat 2PC commit/abort the same as regular xacts in recovery.

Looking at this again ... didn't you just break recoveryStopsBefore?
ISTM the added line

    if (record_info == XLOG_XACT_COMMIT_PREPARED)

needs to be

    else if (record_info == XLOG_XACT_COMMIT_PREPARED)

As it stands, control will reach the "return false" for regular
commit records.

            regards, tom lane

В списке pgsql-committers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: pgsql: Oops, fix recoveryStopsBefore functions for regular commits.