Re: generic pseudotype IO functions?

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: generic pseudotype IO functions?
Дата
Msg-id 52CAD59F.20703@gmx.net
обсуждение исходный текст
Ответ на Re: generic pseudotype IO functions?  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: generic pseudotype IO functions?  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 1/6/14, 10:29 AM, Tom Lane wrote:
>> Pseudotype.c/pg_proc.h are slowly growing a number of pretty
>> useless/redundant copy&pasted functions... Most for cases that are
>> pretty damn unlikely to be hit by users not knowing what they do.
> 
> That's hardly the largest cost associated with inventing a new pseudotype.
> Nor are there lots of new pseudotypes coming down the pike, anyway.

If someone wants to do the work, what's the harm in reducing some code
redundancy?

>> What about adding a pseudotype_in/out that just error out with a generic
>> message?
> 
> This will break some of the function sanity checks in opr_sanity,

Then the tests can be changed.





В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: ERROR: missing chunk number 0 for toast value
Следующее
От: Tom Lane
Дата:
Сообщение: Re: dynamic shared memory and locks