> IMHO that's the single most important task of a review.
Really? I'd say the most important task for a review is "does the patch
do what it says it does?". That is, if the patch is supposed to
implement feature X, does it actually? If it's a performance patch,
does performance actually improve?
If the patch doesn't implement what it's supposed to, who cares what the
code looks like?
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com