Re: Visual Studio 2012 RC

<div class="moz-cite-prefix">On 01/21/2013 08:44 PM, Andrew Dunstan wrote:<br /></div><blockquote
cite="mid:50FD3840.8010700@dunslane.net"type="cite"><br /> On 01/21/2013 04:32 AM, Craig Ringer wrote: <br
/><blockquotetype="cite">On 01/01/2013 10:54 AM, Noah Misch wrote: <br /><blockquote type="cite">On Mon, Oct 15, 2012
at07:53:51AM -0400, Noah Misch wrote: <br /><blockquote type="cite">The only matter still requiring attention is a fix
forIsoLocaleName(). <br /></blockquote> Following off-list coordination with Brar, I went about finishing up this <br
/>patch.  The above problem proved deeper than expected.  For Windows Vista, <br /> Microsoft made RFC 4646 tags the
preferredway to denote a locale in Windows. <br /> Microsoft calls them "locale names".  Starting with Visual Studio
2012,<br /> setlocale() accepts locale names in addition to all the things it previously <br /> accepted.  One can now
usethings like "initdb --locale=zh-CN" and "CREATE <br /> DATABASE foo LC_CTYPE = 'pl'".  This meant updating
win32_langinfo()and <br /> find_matching_ts_config() to handle the new formats.  In passing, I fixed an <br />
uncheckedmalloc() in win32_langinfo(). <br /><br /> In addition to expanding the set of valid locale inputs, VS2012
changesthe <br /> (undocumented) content of _locale_t to hold locale names where it previously <br /> held locale
identifiers. I taught IsoLocaleName() to handle the new material. <br /> I also sought to improve the comments on
IsoLocaleName();its significance was <br /> not previously clear to me.  This thread has some background: <br /><a
class="moz-txt-link-freetext"
href="http://archives.postgresql.org/message-id/4964B45E.5080003@hagander.net">http://archives.postgresql.org/message-id/4964B45E.5080003@hagander.net</a><br
/><br/> Though I'm not entirely sanguine about digging into the officially-opaque <br /> _locale_t, we have been doing
itthat way for several years.  None of the <br /> alternatives are clearly-satisfying.  In particular, I found no good
wayto <br /> look up the code page corresponding to a locale name on pre-Vista systems. <br /> The CRT itself handles
thisby translating locale names to locale identifiers <br /> using a lookup table.  The Gnulib "localename" and
"setlocale"modules are <br /> also interesting studies on the topic. <br /><br /> In previous reviews, I missed the
needto update pgwin32_putenv().  The <br /> addition of VS2010 support had also missed it, so this catches up.  That
<br/> function has other problems, but I will hold them for another patch. <br /><br /> Tester warning: if you
currentlyhave some form of VS2010 installed, including <br /> the compilers of Windows SDK 7.1, beware of this problem:
<br/><a class="moz-txt-link-freetext"
href="http://stackoverflow.com/questions/10888391/link-fatal-error-lnk1123-failure-during-conversion-to-coff-file-invalid-or-c">http://stackoverflow.com/questions/10888391/link-fatal-error-lnk1123-failure-during-conversion-to-coff-file-invalid-or-c</a><br
/></blockquote>FYI, you can properly fix this without uninstalling anything, giving you a system with a working VS 2012
aswell as working SDK 7.1 / VS 2010 SP1 32-bit and 64-bit compilers. <br /><br /> Install the tools in the following
order:<br /><br /> * VS Express 2010: <a class="moz-txt-link-freetext"
href="http://www.microsoft.com/visualstudio/eng/products/visual-studio-2010-express">http://www.microsoft.com/visualstudio/eng/products/visual-studio-2010-express</a><br
/>* Windows SDK 7.1 <br /> * VS 2010 SP1: <a class="moz-txt-link-freetext"
href="http://www.microsoft.com/en-au/download/details.aspx?id=23691">http://www.microsoft.com/en-au/download/details.aspx?id=23691</a><br
/>* VS 2010 SP1 Compiler Update: <a class="moz-txt-link-freetext"
href="http://www.microsoft.com/en-au/download/details.aspx?id=4422">http://www.microsoft.com/en-au/download/details.aspx?id=4422</a><br
/>* VS Express 2012 <br /><br /> Note that SDK 7.1 and VS 2010 will fail to install if you have a newer version of the
Visualc++ 2010 runtime installed. Newer programs often install this for you. As a workaround, you must uninstall the
newerruntime, install Visual Studio, the SDK, and service pack, then reinstall the newer runtime to get the programs
thatrequire it to work again. <br /><br /> I've written more about both of these in the TROUBLESHOOTING section of <a
class="moz-txt-link-freetext"
href="https://github.com/2ndQuadrant/pg_build_win/blob/master/README.md">https://github.com/2ndQuadrant/pg_build_win/blob/master/README.md</a><br
/><br/></blockquote><br /> That's useful information, which should perhaps be put somewhere more obvious for people to
find,like the wiki. <br /><br /> I realise you're doing a lot of stuff, but you seem to be ahead of just about everyone
(includingme and I suspect Magnus) on this, so maybe you could take a peek at this patch?<br /></blockquote><br /> It's
buildingon my Jenkins instance at the moment, to make sure it doesn't break VS 2010 / Windows SDK 7.1 . I've merged it
intoHEAD and pushed to <a
href="https://github.com/ringerc/postgres/tree/vs2012">https://github.com/ringerc/postgres/tree/vs2012</a>;the only
conflictwas a trivial one in the docs.<br /><br /><pre class="moz-signature" cols="72">-- Craig Ringer
<a class="moz-txt-link-freetext" href="http://www.2ndQuadrant.com/">http://www.2ndQuadrant.com/</a>PostgreSQL
Development,24x7 Support, Training & Services</pre>