On 23.10.23 02:26, Michael Paquier wrote:
> 5e4dacb9878c has reminded me that we don't show the version of OpenSSL
> in the output of ./configure. This would be useful to know when
> looking at issues within the buildfarm, and I've wanted that a few
> times.
>
> How about the attached to use the openssl command, if available, to
> display this information? Libraries may be installed while the
> command is not available, but in most cases I'd like to think that it
> is around, and it is less complex than using something like
> SSLeay_version() from libcrypto.
>
> meson already shows this information, so no additions are required
> there. Also, LibreSSL uses `openssl`, right?
The problem is that the binary might not match the library, so this
could be very misleading. Also, meson gets the version via pkg-config,
so the result would also be inconsistent with meson. I am afraid this
approach would be unreliable in the really interesting cases.
> + # Print version of OpenSSL, if command is available.
> + AC_ARG_VAR(OPENSSL, [path to openssl command])
> + PGAC_PATH_PROGS(OPENSSL, openssl)
There is already a call like this in configure.ac, so (if this approach
is taken) you should rearrange things to make use of that one.
> + pgac_openssl_version="$($OPENSSL version 2> /dev/null || echo no)"
> + AC_MSG_NOTICE([using openssl $pgac_openssl_version])