Re: Forbid use of LF and CR characters in database and role names
От | Ideriha, Takeshi |
---|---|
Тема | Re: Forbid use of LF and CR characters in database and role names |
Дата | |
Msg-id | 4E72940DA2BF16479384A86D54D0988A4D820941@G01JPEXMBKW04 обсуждение исходный текст |
Ответ на | Re: Forbid use of LF and CR characters in database and role names (Michael Paquier <michael.paquier@gmail.com>) |
Ответы |
Re: Forbid use of LF and CR characters in database and role names
|
Список | pgsql-hackers |
> > [Summary] > > 1. apply patch and make world > > -> failed because </para> was mistakenly coded <para>. > > > > 2.correct this mistake and make check-world > > -> got 1 failed test: "'pg_dumpall with \n\r in database name'" > > because test script cannot createdb "foo\n\rbar" > > The attached version addresses those problems. I have replaced the test in > src/bin/pg_dump/t/ by tests in src/bin/scripts/t/ to check if the role name > and database name with CR or LF fail to be created. I have as well added a test > for initdb when the data directory has an incorrect character in 0002. Thanks for your modification. I applied your fixed patch and new one, and confirmed the applied source passed the tests successfully. And I also checkedmanually the error messages were emitted successfully when cr/lf are included in dbname or rolename or data_directory. AFAICT, this patch satisfies the concept discussed before. So I’ve switched this patch “Ready for Committer”. Regards, Ideriha, Takeshi
В списке pgsql-hackers по дате отправления: