On 08/02/11 15:44, Hitoshi Harada wrote:
> 2011/2/8 Steve Singer <ssinger_pg@sympatico.ca>:
>> On 11-02-07 10:37 PM, Robert Haas wrote:
>>
>>> - The PL/python extravaganza. I'm not really clear where we stand
>>> with this. There are a lot of patches here.
>>>
>>
>> Some of the patches have been committed a few others are ready (or almost
>> ready) for a committer. The table function one is the only one in
>> 'waiting for author'
>
> I didn't quite finished my reviews on pl/python patches yet, but it
> seems that "don't remove argument" will be easy to review and unlikely
> to have issues. "quote functions" can be committed already as-is.
> "table function" should be in if Jan sends another patch soon. "custom
> datatype parser" looks premature yet, though we want to give more
> feedbacks about its design. I'm not sure about other patches.
From the outstanding PL/Python patches:
* invalidate composites - it fixes a TODO item and is a general
improvement, although the case being fixed is rather rare. Should be
straightforward to review, it's small and localized.
* tracebacks - IMHO a big improvement, but should get more testing than
I gave it, as traversing Python stacks tends to be tricky. Still, it's
very localized (basically just getting a traceback string).
* table functions - I'm working on this one, should have an update today
* custom datatype parsers - more of a PoC, and because the discussion
about hstores in PL/Python died down I decided to go ahead and send a
patch implementing the last idea from that thread. I'm fine with it not
making 9.1 because this should be designed carefully, and will affect
decisions similar to those that are now being taken WRT arrays in PL/Perl.
* custom SPI exceptions - I'd really like this one to go in, because it
allows writing UPSERT-kind functions in PL/Python very easily, and it's
just a handful of lines of code
* don't remove arguments - a bugfix, really, and a very small one
So from the above, I'd say custom datatype parsers could get rejected if
noone feels like having a discussion about it for 9.1. Table functions,
custom SPI exceptions and tracebacks are niceties that if postponed to
9.2 will just mean that many features less in 9.1. The rest is bordering
on bugfixes, and I think should go in.
Cheers,
Jan